Skip to content

Fix ReactImageView warning by conditionally rendering buttonIcon #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ReactImageView warning by conditionally rendering buttonIcon #2609

wants to merge 1 commit into from

Conversation

geoffcfchen
Copy link

Summary

This PR fixes the warning:

WARN ReactImageView: Image source "null" doesn't exist

The issue was caused by rendering an Animated.Image component even when buttonIcon was null.
This fix ensures that Animated.Image is only rendered if buttonIcon exists.

Changes

  • Wrapped the Animated.Image component inside a conditional check (buttonIcon ? ... : null).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geoffcfchen